From 18813c2e31a70eb34e3d18c5784fd88ccc2c8232 Mon Sep 17 00:00:00 2001 From: Luca <61653175+iu2frl@users.noreply.github.com> Date: Thu, 11 Dec 2025 17:41:52 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Florian (DF2ET) --- application/libraries/Callbook.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/application/libraries/Callbook.php b/application/libraries/Callbook.php index 0bc80ab56..556b65b17 100644 --- a/application/libraries/Callbook.php +++ b/application/libraries/Callbook.php @@ -26,7 +26,7 @@ class Callbook { // Parse each callbook in the array until we get a valid result foreach ($source_callbooks as $source) { $callbook = $this->queryCallbook($callsign, $source); - if (!isset($callbook['error'])) { + if (!isset($callbook['error']) || $callbook['error'] == '') { break; } } @@ -80,7 +80,7 @@ class Callbook { $callbook['error'] = 'No callbook defined. Please review configuration.'; } - log_message('debug', 'Callbook lookup for '.$callsign.' using '.$source.': '.(isset($callbook['error']) ? $callbook['error'] : 'Success')); + log_message('debug', 'Callbook lookup for '.$callsign.' using '.$source.': '.((($callbook['error'] ?? '' ) != '') ? $callbook['error'] : 'Success')); return $callbook; }