From 5e2ed44706c7dbb767270dbfbc8ebe8915f60730 Mon Sep 17 00:00:00 2001 From: Szymon Porwolik Date: Tue, 11 Nov 2025 17:00:17 +0100 Subject: [PATCH] Remove redundant trigger('change') call in setFrequency The frequency change event is already triggered conditionally when fromWaterfall=false, so the unconditional trigger on the first line was redundant and could cause the change handler to execute twice. --- assets/js/dxwaterfall.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/assets/js/dxwaterfall.js b/assets/js/dxwaterfall.js index aeb05ab21..2f7f46e00 100644 --- a/assets/js/dxwaterfall.js +++ b/assets/js/dxwaterfall.js @@ -6248,9 +6248,10 @@ function setFrequency(frequencyInKHz, fromWaterfall) { } // Update frequency field with value in Hz - $('#frequency').val(frequencyInKHz * 1000).trigger('change'); + $('#frequency').val(frequencyInKHz * 1000); - // Also trigger change event unless called from waterfall + // Trigger change event to update calculated fields and unit display + // Skip trigger when called from waterfall to prevent recursive updates if (!fromWaterfall) { $('#frequency').trigger('change'); }