From 505e6ba4a93a9936da594c829d0c556bf6179af7 Mon Sep 17 00:00:00 2001
From: HB9HIL <fabian.berg@hb9hil.org>
Date: Wed, 15 Jan 2025 22:33:55 +0100
Subject: [PATCH] show hint about qrz.com login credentials. QRZ.com needs your
 callsign as username. Email causes issues

---
 application/config/config.sample.php |  2 +-
 install/config/config.php            |  2 +-
 install/index.php                    | 17 +++++++++++++++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/application/config/config.sample.php b/application/config/config.sample.php
index 6c871f3d0..4c4ce6d5a 100644
--- a/application/config/config.sample.php
+++ b/application/config/config.sample.php
@@ -37,7 +37,7 @@ $config['display_freq'] = true;
 | QRZ Login Options
 |--------------------------------------------------------------------------
 |
-| 	'qrz_username'	QRZ.com user login
+| 	'qrz_username'	QRZ.com user login (callsign, not email)
 |	'qrz_password'	QRZ.com user password
 |	'use_fullname'  Get full names from QRZ, may not be GDPR compliant
 */
diff --git a/install/config/config.php b/install/config/config.php
index ec0d71cc2..d5a9b5fd5 100644
--- a/install/config/config.php
+++ b/install/config/config.php
@@ -37,7 +37,7 @@ $config['display_freq'] = true;
 | QRZ Login Options
 |--------------------------------------------------------------------------
 |
-| 	'qrz_username'	QRZ.com user login
+| 	'qrz_username'	QRZ.com user login (callsign, not email)
 |	'qrz_password'	QRZ.com user password
 |	'use_fullname'  Get full names from QRZ, may not be GDPR compliant
 */
diff --git a/install/index.php b/install/index.php
index ae4b6917f..34e76d011 100644
--- a/install/index.php
+++ b/install/index.php
@@ -391,6 +391,10 @@ if (!file_exists('.lock')) {
 														</div>
 													</div>
 												</div>
+												<div class="alert alert-info" id="qrz_hint" style="display: none; margin-top: 10px;">
+													<p><i class="fas fa-lightbulb"></i> <?= __("Good to know:"); ?></p>
+													<?= __("Use your callsign as your username for QRZ.com. The XML API does not support email addresses."); ?>
+												</div>
 											</div>
 											<a class="btn btn-sm btn-secondary" id="advancedSettingsButton"><?= __("Advanced Settings"); ?></a>
 											<div class="modal fade" id="advancedSettingsModal" tabindex="-1" aria-labelledby="advancedSettingsModalLabel" aria-hidden="true">
@@ -1405,12 +1409,25 @@ if (!file_exists('.lock')) {
 
 				let directory = $('#directory');
 				let websiteurl = $('#websiteurl');
+				let callbook_type = $('#global_call_lookup');
 				let callbook_username = $('#callbook_username');
 				let callbook_password = $('#callbook_password');
 
 				// On Page Load
 				$(document).ready(function() {
 
+					if (callbook_type.val() === 'qrz') {
+						$('#qrz_hint').show();
+					}
+
+					callbook_type.on('change', function() {
+						if (callbook_type.val() === 'qrz') {
+							$('#qrz_hint').show();
+						} else {
+							$('#qrz_hint').hide();
+						}
+					});
+
 					$('#advancedSettingsButton').click(function() {
 						$('#advancedSettingsModal').modal('show');
 					});