From 6ea710ff27d57ff05d1089451a27aa3a5e63466b Mon Sep 17 00:00:00 2001
From: HB9HIL <fabian.berg@hb9hil.org>
Date: Fri, 24 May 2024 21:36:46 +0200
Subject: [PATCH] move js to a dedicated file

---
 application/controllers/Activators.php        |  8 ++-
 application/views/activators/index.php        |  2 +-
 application/views/interface_assets/footer.php | 70 +------------------
 assets/js/sections/activators.js              | 62 ++++++++++++++++
 4 files changed, 70 insertions(+), 72 deletions(-)
 create mode 100644 assets/js/sections/activators.js

diff --git a/application/controllers/Activators.php b/application/controllers/Activators.php
index 73d01fe96..b2d056a94 100644
--- a/application/controllers/Activators.php
+++ b/application/controllers/Activators.php
@@ -17,7 +17,6 @@ class Activators extends CI_Controller
 
     public function index()
     {
-        // Render Page
         $data['page_title'] = "Gridsquare Activators";
 
         $this->load->model('Activators_model');
@@ -36,9 +35,14 @@ class Activators extends CI_Controller
         $data['activators_vucc_array'] = $this->Activators_model->get_activators_vucc($band, $this->input->post('leogeo'));
         $data['bandselect'] = $band;
 
+        $footerData = [];
+		$footerData['scripts'] = [
+			'assets/js/sections/activators.js?' . filemtime(realpath(__DIR__ . "/../../assets/js/sections/activators.js")),
+		];
+
         $this->load->view('interface_assets/header', $data);
         $this->load->view('activators/index');
-        $this->load->view('interface_assets/footer');
+        $this->load->view('interface_assets/footer', $footerData);
     }
 
     public function details()
diff --git a/application/views/activators/index.php b/application/views/activators/index.php
index 8ecedd01a..7bbee459d 100644
--- a/application/views/activators/index.php
+++ b/application/views/activators/index.php
@@ -16,7 +16,7 @@
                 </select>
             </div>
         </div>
-        <div class="mb-3 row" id="leogeo">
+        <div class="mb-3 row" id="leogeo" style="display: none;">
             <label class="col-md-1 control-label" for="leogeo">LEO/GEO</label>
             <div class="col-md-3">
                 <select id="leogeo" name="leogeo" class="form-select">
diff --git a/application/views/interface_assets/footer.php b/application/views/interface_assets/footer.php
index 8bc899375..5b4ff1bd7 100644
--- a/application/views/interface_assets/footer.php
+++ b/application/views/interface_assets/footer.php
@@ -1981,75 +1981,7 @@ $(document).ready(function(){
             }
         </script>
         <?php } ?>
-    <?php if ($this->uri->segment(1) == "activators") { ?>
-        <script>
-            $('.activatorstable').DataTable({
-                "pageLength": 25,
-                responsive: false,
-                ordering: false,
-                "scrollY":        "500px",
-                "scrollCollapse": true,
-                "paging":         false,
-                "scrollX": true,
-                "language": {
-                    url: getDataTablesLanguageUrl(),
-                },
-                dom: 'Bfrtip',
-                buttons: [
-                    'csv'
-                ]
-            });
-
-            // change color of csv-button if dark mode is chosen
-            if (isDarkModeTheme()) {
-                $(".buttons-csv").css("color", "white");
-            }
-
-      $(document).ready(function(){
-         $('#band').change(function()
-         {
-            if($(this).val() == "SAT")
-            {
-               $('#leogeo').show();
-            } else {
-               $('#leogeo').hide();
-            }
-         });
-         <?php if ($this->input->post('band') != "SAT") { ?>
-         $('#leogeo').hide();
-         <?php } ?>
-      });
-            function displayActivatorsContacts(call, band, leogeo) {
-                var baseURL= "<?php echo base_url();?>";
-                $.ajax({
-                    url: baseURL + 'index.php/activators/details',
-                    type: 'post',
-                    data: {'Callsign': call,
-                        'Band': band,
-                        'LeoGeo': leogeo
-                    },
-                    success: function(html) {
-                        BootstrapDialog.show({
-                            title: lang_general_word_qso_data,
-                            size: BootstrapDialog.SIZE_WIDE,
-                            cssClass: 'qso-was-dialog',
-                            nl2br: false,
-                            message: html,
-                            onshown: function(dialog) {
-                               $('[data-bs-toggle="tooltip"]').tooltip();
-                            },
-                            buttons: [{
-                                label: lang_admin_close,
-                                action: function (dialogItself) {
-                                    dialogItself.close();
-                                }
-                            }]
-                        });
-                    }
-                });
-            }
-        </script>
-        <?php } ?>
+    
 
     <?php if ($this->uri->segment(1) == "mode") { ?>
 		<script src="<?php echo base_url(); ?>assets/js/sections/mode.js"></script>
diff --git a/assets/js/sections/activators.js b/assets/js/sections/activators.js
new file mode 100644
index 000000000..e026a78e7
--- /dev/null
+++ b/assets/js/sections/activators.js
@@ -0,0 +1,62 @@
+$(".activatorstable").DataTable({
+	pageLength: 25,
+	responsive: false,
+	ordering: false,
+	scrollY: "500px",
+	scrollCollapse: true,
+	paging: false,
+	scrollX: true,
+	language: {
+		url: getDataTablesLanguageUrl(),
+	},
+	dom: "Bfrtip",
+	buttons: ["csv"],
+});
+
+$(document).ready(function () {
+
+	let bandselect = $('#band');
+
+	showHideLeoGeo(bandselect);
+	bandselect.change(function () {
+		showHideLeoGeo(bandselect);
+	});
+
+});
+
+function showHideLeoGeo(bandselect) {
+
+	if (bandselect.val() == "SAT") {
+		$("#leogeo").show();
+	} else {
+		$("#leogeo").hide();
+	}
+}
+
+function displayActivatorsContacts(call, band, leogeo) {
+	$.ajax({
+		url: base_url + "index.php/activators/details",
+		type: "post",
+		data: { Callsign: call, Band: band, LeoGeo: leogeo },
+		success: function (html) {
+			BootstrapDialog.show({
+				title: lang_general_word_qso_data,
+				size: BootstrapDialog.SIZE_WIDE,
+				cssClass: "qso-was-dialog",
+				nl2br: false,
+				message: html,
+				onshown: function (dialog) {
+					$('[data-bs-toggle="tooltip"]').tooltip();
+				},
+				buttons: [
+					{
+						label: lang_admin_close,
+						action: function (dialogItself) {
+							dialogItself.close();
+						},
+					},
+				],
+			});
+		},
+	});
+}