Apply suggestions from code review

Co-authored-by: Florian (DF2ET) <github@florian-wolters.de>
This commit is contained in:
Luca
2025-12-11 17:41:52 +01:00
committed by GitHub
parent dfe682b4bf
commit 18813c2e31

View File

@@ -26,7 +26,7 @@ class Callbook {
// Parse each callbook in the array until we get a valid result
foreach ($source_callbooks as $source) {
$callbook = $this->queryCallbook($callsign, $source);
if (!isset($callbook['error'])) {
if (!isset($callbook['error']) || $callbook['error'] == '') {
break;
}
}
@@ -80,7 +80,7 @@ class Callbook {
$callbook['error'] = 'No callbook defined. Please review configuration.';
}
log_message('debug', 'Callbook lookup for '.$callsign.' using '.$source.': '.(isset($callbook['error']) ? $callbook['error'] : 'Success'));
log_message('debug', 'Callbook lookup for '.$callsign.' using '.$source.': '.((($callbook['error'] ?? '' ) != '') ? $callbook['error'] : 'Success'));
return $callbook;
}